[Laszlo-dev] For Review: Change 20061031-maxcarlson-l Summary: UPDATED: Fix enter key in multiline inputtext, fix multiline text, add password input type, all text metrics identical in swf and dhtml

[Max Carlson]

I am running the latest svn-bash.  For some reason, my message gets 
truncated and the checkin URL is never appended :(.  Perhaps my checkin 
message is too detailed?  I thought maybe this was happening because I 
was including test URLs before - because the message was truncated right 
after my first URL, so I stripped off the http://.  I guess I'm still 
having the same problem :(.  It looks like something in these lines is 
messing up the change:

Details: Fixed enter key in multiline inputtext, fix regression in 
multiline text, add password field, added setMaxLength() to DHTML, 
metrics test legals/test/lztest/lztest-textheight.lzx passes in both swf 
and dhtml and are visually identical.

Tests: Comparing 
legals/test/lztest/lztest-textheight.lzx?lzr=dhtml&debug=true vs 
legals/test/lztest/lztest-textheight.lzx?lzr=swf7&debug=true should pass 
in swf and dhtml and should be visually identical.  also, 
legals/examples/components/edittext_example.lzx?lzr=dhtml allows the 
enter key in multiline text and password fields show ***.

I filed a bug here: http://jira.openlaszlo.org/jira/browse/LPP-2995

I'll send the change again - this time I'll paste the Details and Test 
lines in manually...

-Max

P T Withington wrote:
> Hey Max, can you make sure your svn-bash is up to date?  You are not 
> sending along the change package reference with these messages, so we 
> can't review.
> 
> On 2006-10-31, at 20:27 EST, Max Carlson wrote:
> 
>> Change 20061031-maxcarlson-l by maxcarlson at max-carlsons-computer.local 
>> on 2006-10-31 17:20:20 PST
>>     in /Users/maxcarlson/openlaszlo/legals
>>
>> Summary: UPDATED (for the last time): Fix enter key in multiline 
>> inputtext, fix multiline text, add password input type, all text 
>> metrics identical in swf and dhtml
>>
>> New Features:
>>
>> Bugs Fixed: LPP-2900 - Don't snarf enter (and other keys) when editing 
>> an inputtext
>>
>> Technical Reviewer: hqm
>> QA Reviewer: ptw
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: Fixed enter key in multiline inputtext, fix regression in 
>> multiline text, add password field, added setMaxLength() to DHTML,  
>> metrics test legals/test/lztest/lztest-textheight.lzx passes in both 
>> swf and dhtml and are visually identical.
>>
>> Tests: Comparing 
>> legals/test/lztest/lztest-textheight.lzx?lzr=dhtml&debug=true vs 
>> legals/test/lztest/lztest-textheight.lzx?lzr=swf7&debug=true should 
>> pass in swf and dhtml and should be visually identical.  also, 
>> legals/examples/components/edittext_example.lzx?lzr=dhtml allows the 
>> enter key in multiline text and password fields show ***.
>