[Laszlo-dev] For Review: Change 39963 Summary: Fix two renaming bugs

[Henry Minsky]

I think this fixed the bug with the 2nd load failing in the demo app.
Or else something else did... it works for me now..


On 3/2/06, P T Withington <ptw at openlaszlo.org> wrote:
>
> Done.
>
> The closure bit is not right.  It was right for registers, but for
> renaming it is not.  So that is a short term fix.  (By not renaming
> closed over vars, they could collide with implicit this slots.)
>
> On 2006-03-02 02:38 EST, Max Carlson wrote:
>
> > Approved, and tested.  Go ahead and check this in - I think it's
> > important for the demo.  Thanks!
> >
> > -Max
> >
> > P T Withington wrote:
> >> Change 39963 by ptw at ptw-legals-2 on 2006/03/01 20:25:48 *pending*
> >>     Summary: Fix two renaming bugs
> >>         Technical Reviewer: hminsky (pending)
> >>     QA Reviewer: max (pending)
> >>     Doc Reviewer: n/a (pending)
> >>         Details: Don't translate identifiers when they are used as
> >>     keys in an object literal.  Don't translate variables that are
> >>     closed over. Don't translate identifiers when they are used as
> >>     member references.
> >>         Tests: visual inspection of buildlfc --runtime=dhtml
> >> Affected files ...
> >> ... //depot/lps-legals/WEB-INF/lps/server/src/org/openlaszlo/sc/
> >> JavascriptGenerator.java#9 edit
> >
> >
> > --
> > Regards,
> > Max Carlson
> > OpenLaszlo.org
>
> _______________________________________________
> Laszlo-dev mailing list
> Laszlo-dev at openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
>



--
Henry Minsky
Software Architect
hminsky at laszlosystems.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20060302/e6e8371a/attachment.html