[Laszlo-dev] For Review: Change 39893 Summary: Use correct names for accessing Attr fields
P T Withington
ptw at openlaszlo.org
Wed Mar 1 14:03:41 EST 2006
Dunno. Perhaps an Attr is a Node in most browsers? Actually, the
thing that made this work in Opera is that for some reason some
elements of Node.attributes in Opera are undefined, so checking that
the element is defined before trying to access it was the ticket.
But it seems right to use the documented property names too.
On 2006-03-01, at 13:43 EST, Henry Minsky wrote:
> Were attributes totally broken before this change? Or did some
> subclassing allow nodeName to work on attribute?
> On 3/1/06, P T Withington <ptw at openlaszlo.org> wrote:
>> Change 39893 by ptw at ptw-legals-2 on 2006/03/01 10:19:02 *pending*
>> Summary: Use correct names for accessing Attr fields
>> Technical Reviewer: hminsky (pending)
>> QA Reviewer: max (pending)
>> Doc Reviewer: n/a (pending)
>> Details: According to w3c and all documentation I have found,
>> the properties of an Attr object (what Node.attributes is an
>> array of) are `name`, `specified`, and `value'. This change
>> makes the et demo work in Opera.
>> Tests: demos/et/app.lzx?lzr=dhtml in Opera and Firefox.
>> the reviewer verify that this does not break IE?
>> Affected files ...
>> ... //depot/lps-legals/lps/includes/lfc/lzdataset.js#24 edit
>> Laszlo-dev mailing list
>> Laszlo-dev at openlaszlo.org
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com
More information about the Laszlo-dev